Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keyword to account for changes to watchdog API. #3205

Closed
wants to merge 1 commit into from

Conversation

davidraker
Copy link
Contributor

@davidraker davidraker commented Jan 24, 2025

Description

The watchdog package added a requirement for keyword arguments in version 5.0.0. The current version watchdog is 6.0.0, so new environments will fail when the VolttronHomeFileReloader or AbsolutePathFileReloader are used. This affects the web API on startup, since VolttronHomeFileReloaders is used for web-users.json.

Fixes #3200

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Started Volttron with and without the change while a bind-web-address was set. The error described in #3200 is present without the fix and no longer appears with the fix.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@craig8
Copy link
Contributor

craig8 commented Jan 24, 2025

@davidraker please fix the issue with the vctl tests before I merge. @rlutes

@davidraker davidraker closed this Jan 24, 2025
@davidraker davidraker deleted the file_reloader branch January 24, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants